Update cache to ignore values over 250 characters (D1118) #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droberts-ctrlo
changed the title
droberts-ctrlo
force-pushed
the
calc-cache-change
branch
from
78a6489 to
cf79966
Compare
What do you mean by "update insert the value"? |
Contributor
Author
Fixed |
- Fix incorrect return on calc cache code - Add unit test to ensure correct write operation
pawelwlod
reviewed
Jan 26, 2026
abeverley
reviewed
Jan 28, 2026
Contributor
abeverley
left a comment
abeverley
left a comment
There was a problem hiding this comment.
Thanks Dave, good work on getting the test added. A bit more to do though I'm afraid...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code checks the
%valueshash and does not insert the value into the cache should there be any values over 250 characters inserted into the field.